From 1537a263af5cd865107ad051c41105a1534e0074 Mon Sep 17 00:00:00 2001 From: Jim Blandy Date: Tue, 2 Mar 1993 07:33:17 +0000 Subject: [PATCH] * simple.el (kill-region): If the buffer is read-only, call `barf-if-buffer-read-only' instead of just `ding', to get the appropriate error condition and message. * simple.el (insert-buffer): Make sure this returns nil. * simple.el (quoted-insert): Use insert-char, instead of writing out the loop. --- lisp/simple.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index efe38907cb0..4276478f844 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -65,9 +65,7 @@ use overstrike as your normal editing mode, you can use this function to insert characters when necessary." (interactive "*p") (let ((char (read-quoted-char))) - (while (> arg 0) - (insert char) - (setq arg (1- arg))))) + (insert-char char arg))) (defun delete-indentation (&optional arg) "Join this line to previous and fix up whitespace at join. @@ -988,7 +986,8 @@ to make one entry in the kill ring." ;; the region's text in the kill ring, anyway. (buffer-read-only (copy-region-as-kill beg end) - (ding)) + ;; This should always barf, and give us the correct error. + (barf-if-buffer-read-only)) ;; In certain cases, we can arrange for the undo list and the kill ;; ring to share the same string object. This code does that. @@ -1109,7 +1108,8 @@ BUFFER may be a buffer or a buffer name." (setq start (point-min) end (point-max))) (insert-buffer-substring buffer start end) (setq newmark (point))) - (push-mark newmark))) + (push-mark newmark)) + nil) (defun append-to-buffer (buffer start end) "Append to specified buffer the text of the region. -- 2.30.2